Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: PR to update pull request template #7268

Merged
merged 1 commit into from
Apr 6, 2022
Merged

chore: PR to update pull request template #7268

merged 1 commit into from
Apr 6, 2022

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Apr 6, 2022

This PR will notify contributors to not submit any code changes to the main branch

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

This PR will notify contributors to not submit any code changes to the main branch
@tejal29 tejal29 requested a review from a team as a code owner April 6, 2022 19:53
@tejal29 tejal29 requested a review from MarlonGamez April 6, 2022 19:53
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle
Copy link
Contributor

Might want to make an associated issue/Todo so we don't forget to remove this

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #7268 (53fa4ae) into main (290280e) will decrease coverage by 1.98%.
The diff coverage is 56.96%.

@@            Coverage Diff             @@
##             main    #7268      +/-   ##
==========================================
- Coverage   70.48%   68.49%   -1.99%     
==========================================
  Files         515      560      +45     
  Lines       23150    26507    +3357     
==========================================
+ Hits        16317    18156    +1839     
- Misses       5776     7096    +1320     
- Partials     1057     1255     +198     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 224 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tejal29 tejal29 mentioned this pull request Apr 6, 2022
@tejal29
Copy link
Contributor Author

tejal29 commented Apr 6, 2022

done #7269

@tejal29 tejal29 merged commit e50fc5e into main Apr 6, 2022
@tejal29 tejal29 deleted the tejal29-patch-1 branch April 6, 2022 20:39
MarlonGamez added a commit that referenced this pull request Apr 14, 2022
bskaplan pushed a commit to bskaplan/skaffold that referenced this pull request Apr 26, 2022
This PR will notify contributors to not submit any code changes to the main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants