Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document multi-stage dockerfile limitations of filesync #6526

Conversation

briandealwis
Copy link
Member

Fixes: #6525

Description
Document the limitations of the infer sync rules with multi-stage dockerfiles.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #6526 (c7e1ed6) into main (997edc8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6526      +/-   ##
==========================================
- Coverage   70.43%   70.41%   -0.02%     
==========================================
  Files         515      515              
  Lines       23127    23127              
==========================================
- Hits        16289    16286       -3     
- Misses       5780     5783       +3     
  Partials     1058     1058              
Impacted Files Coverage Δ
pkg/skaffold/log/stream/stream.go 71.42% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3839f4...c7e1ed6. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarlonGamez MarlonGamez merged commit 4700257 into GoogleContainerTools:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the limitations of the infer sync with multi-stage Dockerfiles
3 participants