refactor ShouldDisplaySurveyPrompt from config package to survey

[tejal29]

relates to #6166

Should merge after #6185

Refactor config.ShouldDisplaySurveyPrompt to survey.ShouldDisplaySurveyPrompt and align with method survey.DisplaySurveyPrompt

Motivation:
With changes proposed in #6185, we will need the survey package to handle parsing of skaffold.yaml to check if any relevant active surveys need to be shown to users.

In this Pr

1. Move ShouldDisplaySurveyPrompt, isSurveyPromptDisabled and recentlyPromptedOrTaken to survey package
2. Move TestShouldDisplaySurveyPrompt , TestRecentlyPromptedOrTaken and TestIsSurveyPromptDisabled to survey package
3. remove static current variable used for testing in survey package as mentioned by @briandealwis in Add survey config and framework to show feature surveys to skaffold users. #6185 (comment)
   Note: unfortunately we cant get rid of current in https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/config/util.go#L56 yet as the WriteConfig tests override it.
4. Add timeutil package which has utility method to parse date string and compare time.

[codecov]

Codecov Report

Merging #6187 (2b6541b) into master (12e9772) will decrease coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #6187      +/-   ##
==========================================
- Coverage   71.09%   71.08%   -0.01%     
==========================================
  Files         484      485       +1     
  Lines       21602    21603       +1     
==========================================
- Hits        15357    15356       -1     
- Misses       5263     5264       +1     
- Partials      982      983       +1     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/cmd.go	73.91% <33.33%> (+0.14%)	⬆️
pkg/skaffold/survey/survey.go	56.66% <83.33%> (+17.77%)	⬆️
pkg/skaffold/config/util.go	66.82% <100.00%> (-1.70%)	⬇️
pkg/skaffold/timeutil/util.go	100.00% <100.00%> (ø)
pkg/skaffold/util/tar.go	52.87% <0.00%> (-4.60%)	⬇️
pkg/skaffold/docker/parse.go	88.23% <0.00%> (+0.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e9772...2b6541b. Read the comment docs.

[briandealwis]

Is it worth moving recentlyPromptedOrTaken() and isSurveyPromptDisabled() (and tests) into the survey package too?

[briandealwis]

Can we get rid of this for-current-kubectx? Especially since we may now deploy to multiple kubecontexts?

[tejal29]

That needs a separate PR i feel. everywhere global config is resolved based on current context.
Created an issue here #6189

[briandealwis]

I thought the magic reprompting date was 2 weeks, so the 10 days threw me for a loop.

[tejal29]

I thought the magic reprompting date was 2 weeks, so the 10 days threw me for a loop.

I found it out too when test failed.