Fetch and set up secret for skaffold-metrics project #6104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deploy/setup-secret.sh
Outdated
| while read -r KEY_ID | ||
| do | ||
| if gsutil cp gs://${BUCKET_ID}/${KEY_ID}.json ${KEY_FILE}; then | ||
| if gsutil cp gs://${BUCKET_ID}/${LATEST_GCS_PATH}.json ${KEY_FILE}; then |
There was a problem hiding this comment.
LATEST_GCS_PATH=keys.json so I think this will be keys.json.json
| @@ -30,10 +31,10 @@ done | |||
|
|
|||
| function download_existing_key() { | |||
| # Download a valid key created within the past two weeks. | |||
| KEY_IDS=$(gcloud iam service-accounts keys list --iam-account=metrics-writer@k8s-skaffold.iam.gserviceaccount.com --project=k8s-skaffold --managed-by=user --filter="validAfterTime>-P2W" --format="value(name)") | |||
| KEY_IDS=$(gcloud iam service-accounts keys list --iam-account=metrics-writer@${METRICS_PROJECT_ID}.iam.gserviceaccount.com --project=${METRICS_PROJECT_ID} --managed-by=user --format="value(name)") | |||
There was a problem hiding this comment.
nit: is this still needed? --filter="validAfterTime>-P2W" I'm guessing that w/ the new project and expiration date it isn't, just verifying
There was a problem hiding this comment.
yeah. new keys live longer and hence we don't need that check.
tejal29
force-pushed
the
use_skaffold_metrics_prj
branch
from
5d7ae87 to
118a557
Compare
tejal29
force-pushed
the
use_skaffold_metrics_prj
branch
from
118a557 to
b9c4244
Compare
Codecov Report
@@ Coverage Diff @@
## master #6104 +/- ##
=======================================
Coverage 70.18% 70.18%
=======================================
Files 475 475
Lines 18156 18156
=======================================
Hits 12743 12743
Misses 4476 4476
Partials 937 937
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
No code change required for instrumentation as project id is derived from the secret itself.
Earlier dashboard can be used as k8s-skaffold is defines as scoped project https://cloud.google.com/monitoring/settings#concept-scope