Add SKAFFOLD_CMDLINE environment variable to pass command-line #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2350
Description
This PR adds support for a new
SKAFFOLD_CMDLINEenvironment variable. If found, Skaffold parses the value and treats it as the command-line. This allows running Skaffold with no arguments.Helm 3.1 adds support for specifying a post-processor, a 0-argument command that may transform the rendered Kubernetes manifests just prior to be deployed. The
debugsupport for Helm (coming soon) usesskaffoldas the post-processor and usesSKAFFOLD_CMDLINEto set the command and arguments.I think we can keep this as an internal feature.