Support explicitly specifying per-artifact language runtimes #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandealwis
requested review from
balopat,
chanseokoh,
dgageot,
loosebazooka,
nkubala,
TadCordle and
tejal29
as code owners
Codecov Report
|
|
@briandealwis Could you please rebase? |
dgageot
reviewed
Apr 14, 2020
| @@ -28,6 +28,8 @@ import ( | |||
| type Artifact struct { | |||
| ImageName string `json:"imageName"` | |||
| Tag string `json:"tag"` | |||
| // Config is the corresponding artifact object from `skaffold.yaml`. | |||
| Config latest.Artifact `json:"-"` | |||
There was a problem hiding this comment.
I'm not sure I understand where this gets populated from?
There was a problem hiding this comment.
Hrmm that seems to have somehow disappeared. And clearly a test is needed.
|
@briandealwis what's the latest on this? |
|
It needs a substantial update. But it should be much easier with the new configs. |
|
closing this for now, please reopen when its ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2350
Merge after: #3942 (introduces
v2beta2)Description
This PR adds a new
runtimesattribute to build artifacts to allow a user to explicitly specify the set of language runtimes used in that artifact. This ability will be used byskaffold debugand helps with Go debugging, wheredebug's heuristics depend on defining some set of Go environment variables (e.g.,GOGC,GODEBUG,GOTRACEBACK). It also helps with Buildpacks as there is no way for users to cause a new environment variables to be added to the runtime image.For example,
examples/getting-started/skaffold.yamlwill have the following change which will allow us to setup an Alpine-compatible Delve debugger.build: artifacts: - image: skaffold-example + runtimes: [go, musl]Skaffold's deployers do not have any access to the original configuration model (as defined by the
skaffold.yaml). To bridge this disconnect, I've added a new field topkg/skaffold/build'sArtifactto include the corresponding configuration artifact definition:type Artifact struct { ImageName string `json:"imageName"` Tag string `json:"tag"` + // Config is the corresponding artifact object from `skaffold.yaml`. + Config latest.Artifact `json:"-"` }User facing changes (remove if N/A)
Adds new
runtimesfield.Follow-up Work (remove if N/A)
I need to create a MUSL-based Delve container (GoogleContainerTools/container-debug-support#30) and then add support to
transform_goto use the appropriate image depending on themuslorglibcruntime.