Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable finding alternative builders nested under Jib projects #3671

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Feb 10, 2020

Fixes #3654.

Now the output of skaffold init --analyze --skip-deploy --XXenableJibInit | jq on the java-guestbook Cloud Code sample is:

{
  "builders": [
    {
      "name": "Jib Maven Plugin",
      "payload": {
        "path": "pom.xml"
      }
    },
    {
      "name": "Jib Maven Plugin",
      "payload": {
        "path": "pom.xml"
      }
    },
    {
      "name": "Docker",
      "payload": {
        "path": "backend/Dockerfile"
      }
    },
    {
      "name": "Docker",
      "payload": {
        "path": "frontend/Dockerfile"
      }
    }
  ]
}

note, the repeated pom.xml is still due to GoogleContainerTools/jib#2262

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #3671 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/builders.go 94.36% <100%> (+0.03%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@balopat balopat force-pushed the fix_jib_nested_init branch from 18193fc to 2682ad6 Compare February 10, 2020 06:21
@balopat balopat assigned balopat and nkubala and unassigned balopat Feb 10, 2020
@nkubala nkubala merged commit d6982bc into GoogleContainerTools:master Feb 10, 2020
@nkubala nkubala deleted the fix_jib_nested_init branch February 10, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold init --analyze is not returning full builder list
3 participants