Environment variables set in before hook does not get passed to build arg

[connorjburton]

Expected behavior

Setting an environment variable in the before hook and using that in buildArgs should correctly pass the value.

Actual behavior

No value gets passed.

Information

• Skaffold version: 2.4.1
• Operating system: Ventura 13.3.1 (a)
• Installed via: Homebrew
• Contents of skaffold.yaml:

apiVersion: skaffold/v4beta3
kind: Config
build:
  artifacts:
    - image: test-image
      context: .
      docker:
        buildArgs:
          HELLO: "{{ .HELLO }}"
      hooks:
        before:
          - command:
              - bash
              - source-env.sh

Steps to reproduce the behavior

1. Clone https://github.com/connorjburton/docker-env-hooks-bug
2. Run skaffold dev -v debug

See this line to prove the env is set

printing hello env value
WORLD

And this line to prove that it's not being passed to docker build

DEBU[0001] Running command: [docker build . --file ...snip.../docker-env-hooks-bug/Dockerfile -t test-image:1f2c197 --build-arg HELLO=<no value> --platform linux/amd64]  subtask=test-image task=Build

[ericzzzzzzz]

Hi, @connorjburton You may be able to set the buildArgs by calling shell command with go template

apiVersion: skaffold/v4beta3
kind: Config
build:
  artifacts:
    - image: test-image
      context: .
      docker:
        buildArgs:
          HELLO: '{{cmd "bash" "source-env.sh"}}'

[connorjburton]

Yes that worked thank you. I changed source-env.sh to this

set -a
source .env set
set +a
eval "echo \${$1}"

So that I could pass multiple build args like this

HELLO: '{{cmd "bash" "source-env.sh" "HELLO"}}'
FOO: '{{cmd "bash" "source-env.sh" "FOO"}}'

[renzodavid9]

Hey @connorjburton, thanks for confirming it worked for you. I'll close this issue, please feel free to reopen or create a new if you need it. Thanks!