`skaffold delete` not working @ HEAD (52c669b7113e37ee8d06f2cdd2a019572a7298b8)

[aaron-prindle]

Currently skaffold delete appears to be broken at head - 52c669b

It seems skaffold delete currently passes 0 manifests to the Delete method. This makes skaffold delete succeed (which is why I assume tests are passing) but not actually delete the proper resources.

This was pointed out initially by @bskaplan who stated:
https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/runner/v2/cleanup.go#L24 is currently passing nil for the manifest list.

Example logs for skaffold v2 (from HEAD)

aprindle@aprindle ~/skaffold/examples/microservices  [main]$ skaffold run
Generating tags...
 - leeroy-web -> leeroy-web:v1.38.0-70-g52c669b71
 - leeroy-app -> leeroy-app:v1.38.0-70-g52c669b71
 - base -> base:v1.38.0-70-g52c669b71
# ... run succeeds

aprindle@aprindle ~/skaffold/examples/microservices  [main]$ skaffold delete
Cleaning up...
 - No resources found

Logs from v1.38.0

aprindle@aprindle ~/skaffold/examples/microservices  [main]$ skaffold-v1.38.0 run
Generating tags...
 - leeroy-web -> leeroy-web:v1.38.0-70-g52c669b71
 - leeroy-app -> leeroy-app:v1.38.0-70-g52c669b71
 - base -> base:v1.38.0-70-g52c669b71
# ... run succeeds

aprindle@aprindle ~/skaffold/examples/microservices  [main]$ skaffold-v1.38.0 delete
Cleaning up...
 - deployment.apps "leeroy-web" deleted
 - service "leeroy-app" deleted
 - deployment.apps "leeroy-app" deleted