Investigate why SanitizeImageName isn't being called

[PriyaModali]

SanitizeImageName isn't being called which is causing the custom test to fail with ko: images.

We need to investigate why SanitizeImageName isn't being called.

[MarlonGamez]

I believe this issue may be resolved with @halvards's proposed implementation of ko as a builder in skaffold. I'm going to hold off on serious investigation into this for now

linking for context:
#5611

[briandealwis]

Ah! @PriyaModali and I had noticed that the image wasn't being rebuilt (#5500) — that it was being cached. It looks like SanitizeImageName() is called from the imageReplacer:

skaffold/pkg/skaffold/kubernetes/manifest/images.go

Lines 80 to 85 in 7aaa1c7

	func newImageReplacer(builds []graph.Artifact) *imageReplacer {
	tagsByImageName := make(map[string]string)
	for _, build := range builds {
	imageName := docker.SanitizeImageName(build.ImageName)
	tagsByImageName[imageName] = build.Tag
	}

which is called to replace image references. I wonder if cached images are not included in the built images passed in here:

skaffold/pkg/skaffold/kubernetes/manifest/images.go

Lines 60 to 64 in 7aaa1c7

	// ReplaceImages replaces image names in a list of manifests.
	func (l *ManifestList) ReplaceImages(builds []graph.Artifact) (ManifestList, error) {
	replacer := newImageReplacer(builds)
	updated, err := l.Visit(replacer)

[halvards]

I can look into this as part of the work for #5611