Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistage Docker Build Cache #3831

Open
no1melman opened this issue Mar 16, 2020 · 7 comments
Open

Multistage Docker Build Cache #3831

no1melman opened this issue Mar 16, 2020 · 7 comments
Labels
area/build area/cache build/docker kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@no1melman
Copy link

no1melman commented Mar 16, 2020

Is the only way to support multistage docker build cache like discussed here to have separate docker builds in the skaffold build section like below (below being the skaffold rep of what is in that link):

build:
  artifacts:
    - image: itamarst/helloworld:compile-stage
      context: .
      docker:
        target: compile-image
        cacheFrom: 
          - itamarst/helloworld:compile-stage
    - image: itamarst/helloworld:latest
      context: .
      docker:
        target: runtime-image
        cacheFrom:
          - itamarst/helloworld:compile-stage
          - itamarst/helloworld:latest

There is no "auto" feature that scans your dockerfile first and caches necessary stages...

This seems bad to me for the reasons of tagging... if you have multiple CD pipelines running, they can't all read and write to helloworld:compile-stage, but if we left it up to the tag policy, how do you get that injected into the runtime-image stage

@tstromberg tstromberg added priority/p2 May take a couple of releases priority/p3 agreed that this would be good to have, but no one is available at the moment. and removed priority/p2 May take a couple of releases labels Apr 20, 2020
@tstromberg
Copy link
Contributor

This seems like a reasonable idea - but also not a high priority for the team at the moment. If you or someone else is willing to make a design proposal, I'd be eager to check it out: https://github.com/GoogleContainerTools/skaffold/tree/master/docs/design_proposals

Help wanted!

@no1melman
Copy link
Author

I would love to contribute to it, but I don't know Go, and currently not in a place to learn it. Hoping if there are any other awesome Go devs who could?

@no1melman
Copy link
Author

Happy to jump on zoom calls and that to talk through it

@tejal29
Copy link
Member

tejal29 commented Jun 8, 2020

@no1melman Please join skaffold-users@. We have a bi-weekly community office hours. More information here https://github.com/GoogleContainerTools/skaffold#community

If that does not work, please let us know and we can schedule something as per your convenience.

@nkubala
Copy link
Contributor

nkubala commented Jun 16, 2020

@no1melman just FYI our next office hours is wednesday 06/24 at 9:30 AM PST!

@no1melman
Copy link
Author

Yup I should be there.

@nkubala
Copy link
Contributor

nkubala commented Jun 24, 2020

@no1melman would be great if you could provide a sample project that we can test this out on!

@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build area/cache build/docker kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

5 participants