fix for #7024

GoogleContainerTools · Feb 16, 2022 · 76edb18 · 76edb18
1 parent 35ec779
commit 76edb18
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/pkg/skaffold/docker/image.go b/pkg/skaffold/docker/image.go
@@ -540,6 +540,10 @@ func (l *localDaemon) TagWithImageID(ctx context.Context, ref string, imageID st
 		return "", err
 	}
 
+	if imageID == "" {
+		log.Entry(ctx).Debugf("generating tag for %s: empty image id\n", ref)
+		return "", nil
+	}
 	uniqueTag := parsed.BaseName + ":" + strings.TrimPrefix(imageID, "sha256:")
 	if err := l.Tag(ctx, imageID, uniqueTag); err != nil {
 		return "", err

diff --git a/pkg/skaffold/docker/image_test.go b/pkg/skaffold/docker/image_test.go
@@ -537,6 +537,10 @@ func TestTagWithImageID(t *testing.T) {
 			imageName:   "!!invalid!!",
 			shouldErr:   true,
 		},
+		{
+			description: "empty image id",
+			imageName:   "ref",
+		},
 	}
 	for _, test := range tests {
 		testutil.Run(t, test.description, func(t *testutil.T) {