Skip to content

Commit

Permalink
fix: Don't add kubectl deployer when cloud run deployer present. (#7731)
Browse files Browse the repository at this point in the history
* fix: add cloud run deployer nil check

* found the culprit which was adding kubectl deployer
  • Loading branch information
tejal29 authored Aug 3, 2022
1 parent 73b0278 commit 49d39fb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/skaffold/schema/defaults/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ func SetDefaultRenderer(c *latest.SkaffoldConfig) {
return
}
if len(c.Render.Generate.RawK8s) > 0 {
if c.Deploy.KubectlDeploy == nil {
if c.Deploy.KubectlDeploy == nil && c.Deploy.CloudRunDeploy == nil {
log.Entry(context.TODO()).Debug("Found raw k8s manifests without cloud run deploy, adding kubectl deployer")
c.Deploy.KubectlDeploy = &latest.KubectlDeploy{}
}
return
Expand Down

0 comments on commit 49d39fb

Please sign in to comment.