-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: locking with bzlmod #73
Conversation
9523dfe
to
936aa5a
Compare
ping @alexeagle |
wksp_file="WORKSPACE" | ||
elif [ -e $BUILD_WORKSPACE_DIRECTORY/WORKSPACE.bazel ]; then | ||
wksp_file="WORKSPACE.bazel" | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should have checked MODULE.bazel too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this in #88, hopefully it'll be merged soon :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround, I really appreciate it!
PR GoogleContainerTools#73 added the `_resolve` and this breaks the buildozer fix / autofix
PR GoogleContainerTools#73 added the `_resolve` and this breaks the buildozer fix / autofix
Bzlmod locking was broken as well, this fixes it and reverts some changes from #70