add methods to allow selection and exclusion of resources by gvk #581
Conversation
natasha41575
changed the title
natasha41575
force-pushed
the
SelectAndExclude
branch
2 times, most recently
from
eec9c4f
to
b022f7a
Compare
natasha41575
force-pushed
the
SelectAndExclude
branch
from
b022f7a
to
f11c238
Compare
go/fn/object.go
Outdated
| } | ||
|
|
||
| // SelectByGvk will return the subset of objects that matches the provided GVK. | ||
| func (o KubeObjects) SelectByGvk(apiVersion, kind string) KubeObjects { |
There was a problem hiding this comment.
Nit: This isn't really selecting by GVK :-) I would expect SelectByGVK to take a schema.GroupVersionKind.
There was a problem hiding this comment.
While I agree with the nit, we already have a func (o *KubeObject) IsGVK(apiVersion, kind string) bool here, so I'm trying to keep things consistent. If we're going to change it so that GVK strictly refers to group, version, and kind (rather than apiVersion and kind), we should do that everywhere. WDYT @mengqiy @yuwenma ?
There was a problem hiding this comment.
yeah, +1 to take a schema.GroupVersionKind. That's also my original thought, but one thing we need to further discuss is that how we can not duplicate kustomize code and at the same time import as less code as possible. for GVK, I think introducing our own version is good especially to support the SQL style syntax.
There was a problem hiding this comment.
changed to use schema.GroupVersionKind instead of apiVersion
There was a problem hiding this comment.
I think the "schema.GroupVersionKind" refer to k8s.io/apimachinery/pkg/runtime/schema
natasha41575
force-pushed
the
SelectAndExclude
branch
from
0167797
to
4c639f3
Compare
natasha41575
force-pushed
the
SelectAndExclude
branch
2 times, most recently
from
1759fa5
to
f30773d
Compare
natasha41575
force-pushed
the
SelectAndExclude
branch
from
f30773d
to
bf04273
Compare
|
@yuwenma I see that you've approved this PR but I've made some more changes that I think should be reviewed before merging, do you mind taking a look? |
Thank you for the change and overall looks great. One last comment about the schema.GroupVersionKind. I'm totally okay to do that in a follow up PR as well :) |
Related to kptdev/kpt#3016
Add methods to the function SDK to allow easily filtering by GVK, name, namespace, labels, annotations, and meta resources.