Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Configs.addResult() instead of throwing exceptions. #145

Merged
merged 1 commit into from
May 14, 2020
Merged

Use Configs.addResult() instead of throwing exceptions. #145

merged 1 commit into from
May 14, 2020

Conversation

frankfarzan
Copy link
Contributor

No description provided.

@frankfarzan frankfarzan requested a review from prachirp May 12, 2020 01:48
@frankfarzan frankfarzan merged commit ed5a64a into master May 14, 2020
prachirp
prachirp reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@prachirp prachirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review

ts/kpt-functions/src/run.ts Show resolved Hide resolved
ts/kpt-functions/src/run.ts Show resolved Hide resolved
ts/kpt-functions/src/run.ts Show resolved Hide resolved
@frankfarzan frankfarzan deleted the exceptions_fix branch May 15, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prachirp prachirp prachirp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankfarzan @prachirp