Support for private registries in the cache warmer

[stijndehaes]

Closes #503

Signed-off-by: Stijn De Haes stijndehaes@gmail.com

Description

Adds support for private registries to the cache warmer

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes unit tests
• Adds integration tests if needed.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Added support for private registries to the cache warmer.

[stijndehaes]

Not sure on how to best write tests for this, if anyone could give me some pointers that would be great :)

I did test it using aws ECR and that worked fine.

[cvgw]

@stijndehaes with some of the recent changes to master there are some conflicts in pkg/cache/warm.go that need to be resolved with your new code.

Specifically, the call to remote.Image is now done inside of the method Warm and remote.Image is passed as an argument.

One possible solution would be to add a new field on the struct Warmer; something like RemoteOptions.

Another option could be to wrap remote.Image in an anonymous function which will pass ropts.

I'm happy to help out.

[tejal29]

@stijndehaes would love to get this in! Let us know how we can help.

[stijndehaes]

@tejal29 @cvgw I will try to fix the conflicts this week! Thank you for the reminder :)

[stijndehaes]

Ok fixed the conflicts and retested with ECR. Everything is working :)

[tejal29]

Thanks @stijndehaes. running kokoro tests and will try to merge this in today.

[cvgw]

Thanks @stijndehaes 👍