Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unpacking archives via ADD #717

Merged
merged 1 commit into from
Aug 19, 2019
Merged

fix unpacking archives via ADD #717

merged 1 commit into from
Aug 19, 2019

Conversation

vm86
Copy link
Contributor

@vm86 vm86 commented Jul 19, 2019

Bugfix: unpacking archives with ADD cos it recieves only a full destination path and ignores WORKDIR's directions.

Dockerfile example:

FROM busybox

WORKDIR /app

ADD test_file.tar .
RUN ls /app

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@vm86
Copy link
Contributor Author

vm86 commented Jul 19, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vm86
Copy link
Contributor Author

vm86 commented Aug 18, 2019

Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@priyawadhwa priyawadhwa merged commit 0694be3 into GoogleContainerTools:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants