Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in extracting hardlinks in multistage builds #456

Merged
merged 4 commits into from
Nov 20, 2018
Merged

Fix bug in extracting hardlinks in multistage builds #456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d67953
Fix bug in extracting hardlinks
Nov 17, 2018
2cf6f52
Fix hardlink unit test
Nov 19, 2018
edd873d
remove unnecessary filepath.Join since dest is always an absolute path
Nov 19, 2018
acd45dc
fixed digests for integration test
Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions integration/dockerfiles/Dockerfile_test_hardlink
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
FROM composer@sha256:5c4bd89217b50125f28e08d9f16414ecb75f90ce9b773605472b35cd55f3e5c0 AS composer
FROM php@sha256:9fe20c8003a12f5907ffdc1d7ec435b4ca4226fa4342b94cec4d66189a439f17
COPY --from=composer /usr/bin/composer /usr/bin/composer
COPY ./ /app
WORKDIR /app
RUN ls -l

# make sure hardlink extracts correctly
FROM jboss/base-jdk@sha256:138591422fdab93a5844c13f6cbcc685631b37a16503675e9f340d2503617a41

FROM gcr.io/kaniko-test/hardlink-base:latest
RUN ls -al /usr/libexec/git-core/git /usr/bin/git /usr/libexec/git-core/git-diff
RUN stat /usr/bin/git
Expand Down
4 changes: 2 additions & 2 deletions pkg/util/fs_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ func extractFile(dest string, hdr *tar.Header, tr io.Reader) error {
return errors.Wrapf(err, "error removing %s to make way for new link", hdr.Name)
}
}

if err := os.Link(filepath.Clean(filepath.Join("/", hdr.Linkname)), path); err != nil {
link := filepath.Join(dest, hdr.Linkname)
if err := os.Link(filepath.Clean(filepath.Join("/", link)), path); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to know why "/". path is essentially filepath.Join(dest, hdr.Name), so it seems reasonable that the first arg to os.Link is filepath.Join(dest, hdr.Linkname), no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing that out! i've removed the unnecessary filepath.Join

return err
}

Expand Down