Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace gometalinter with GolangCI-Lint #349

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Replace gometalinter with GolangCI-Lint #349

merged 3 commits into from
Sep 11, 2018

Commits on Sep 11, 2018

  1. Replace gometalinter with GolangCI-Lint 

    gometalinter is broken @ HEAD, and I looked into why that was. During
that process, I remembered that we took the linting scripts from
skaffold, and found that in skaffold gometalinter was replaced with
GolangCI-Lint:

GoogleContainerTools/skaffold#619

The change made linting in skaffold faster, so I figured instead of
fixing gometalinter it made more sense to remove it and replace it with
GolangCI-Lint for kaniko as well.
    Priya Wadhwa committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    99ab68e View commit details
    Browse the repository at this point in the history

  2. More linting errors

    Priya Wadhwa committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    ccb6259 View commit details
    Browse the repository at this point in the history

  3. Add t.Helper() call to checkLayers for better error logging

    Priya Wadhwa committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    7635421 View commit details
    Browse the repository at this point in the history