-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducing and Fixing #2892 #2893
Reproducing and Fixing #2892 #2893
Conversation
I think I reproduced the bug with a now failing integration test. But I don't understand why the unit tests are failing. Can you help me ? |
Looks like they are just linter issues, shall be fixed with formatting IIUC |
@aaron-prindle I fixed the bug, my new integration test is now passing, but I don't understand why the unit tests are failing. |
Ok the bug is reproduced within an integration test and fixed. Do you plan to release a 1.19.1 soon ? |
Reproducing and Fixing #2892
Description
Firstly : attempt to reproduce in integration tests.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.