Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing slash #2658

Merged

Conversation

pditommaso
Copy link
Contributor

Description

This PR fixes the missing slash in tar:// context example in the README

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

This PR fixes the missing slash in tar:// context example
@aaron-prindle
Copy link
Collaborator

@pditommaso thanks for the fix here! Can you rebase this PR? Currently the PR CI/CD is failing due to a recently fixed issue - if you can rebase this should be all green and we can merge 🙌

@aaron-prindle aaron-prindle merged commit b1a0d57 into GoogleContainerTools:main Oct 31, 2023
6 of 10 checks passed
@pditommaso
Copy link
Contributor Author

Sorry, this remained deep in my inbox. Thanks for merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants