Download docker-credential-gcr from release artifacts #2540
Conversation
ferrastas
force-pushed
the
fix_docker-credential-gcr
branch
from
438db2d
to
916163b
Compare
|
Thank you @ferrastas for flagging this and submitting the PR here! I wasn't aware of this when I recently bumped the tag there. My only concern with the PR is that Kaniko builds images for multiple architectures: and currently I believe this PR does not parameterize the arch (assumes linux_amd64). If you could parameterize the arch s.t. the Dockerfile works for all arch in our |
|
Thanks @aaron-prindle, 😓 I totally missed that... |
As described in GoogleContainerTools#2539, using `go install` with a pinned hash version it installs `1.5.1` in all cases. This seems to be an issue on the upstream project https://github.com/GoogleCloudPlatform/docker-credential-gcr and how go proxy deals with versions. As a temporary solution, we download the compiled version from the release artifacts. Closes GoogleContainerTools#2539 Signed-off-by: Ferran Vidal <ferran.vidal.p@gmail.com>
ferrastas
force-pushed
the
fix_docker-credential-gcr
branch
from
916163b
to
ea63550
Compare
|
@aaron-prindle seems that one of the integration tests is a bit flaky, I cannot retry the failing job, could you do it, please? |
|
Definitely @ferrastas, kicking off the job again now. |
|
@aaron-prindle do you think that you have some time to review and merge this? |
…rTools#2540) As described in GoogleContainerTools#2539, using `go install` with a pinned hash version it installs `1.5.1` in all cases. This seems to be an issue on the upstream project https://github.com/GoogleCloudPlatform/docker-credential-gcr and how go proxy deals with versions. As a temporary solution, we download the compiled version from the release artifacts. Closes GoogleContainerTools#2539 Signed-off-by: Ferran Vidal <ferran.vidal.p@gmail.com>
Fixes #2539
Description
As described in #2539, using
go installwith a pinned hash version it installs1.5.1in all cases.This seems to be an issue on the upstream project https://github.com/GoogleCloudPlatform/docker-credential-gcr and how go proxy deals with versions.
As a temporary solution, we download the compiled version from the release artifacts.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes