-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable cache-copy-layers in multistage builds; closes 2065 #2227
feat: disable cache-copy-layers in multistage builds; closes 2065 #2227
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Looks like a Otherwise lgtm, thanks for sending this |
@imjasonh just so there's no misunderstanding
This is true, but my opinion is that changing Maybe it would be possible to, at this point, restart execution of the entire process from the beginning with And this is only users who have chosen not to pin their dependencies, such as their version of executor. I always pinned the executor image I used in my argo workflows since I wanted to make sure that upstream updates don't change anything unless I want them to. But if somebody doesn't pin the executor, they're saying they're okay with upstream breaking their build on upgrades. And this is a case where upstream breaking your build is a good thing, since you were doing something very bad, you just didn't understand it. |
I'm choosing to interpret the previous "lgtm" as implying that integration tests are not required, and crossing that off |
Should probably also close #1877 on merge |
Fixes #2065
Description
If
CacheCopyLayers
is enabled, and the user is trying to build a multi-stage Dockerfile, exit immediately since this doesn't work properly.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Adds integration tests if needed.See the contribution guide for more details.
Reviewer Notes
Release Notes
Anyone who is currently passing
--cache-copy-layers
with multistage Dockerfiles will have their builds break.