Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go dep to 1.18 #2141

Closed
wants to merge 4 commits into from
Closed

Conversation

imjasonh
Copy link
Collaborator

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Bumps Kaniko dep to 1.18

@imjasonh imjasonh mentioned this pull request Jun 21, 2022
@hypnoce hypnoce mentioned this pull request Jun 27, 2022
2 tasks
@jebatc
Copy link

jebatc commented Jul 6, 2022

Any idea what's going wrong with the unit tests for this commit @imjasonh?

@imjasonh
Copy link
Collaborator Author

imjasonh commented Jul 6, 2022

Any idea what's going wrong with the unit tests for this commit @imjasonh?

As part of this change I also updated how we run the linter, and updated the version of the linter we use, which has found a bunch of new lint isssues. We can force-merge past them (with a repo owner's permission), or someone can go through and fix and/or ignore them.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Feb 4, 2023

#2386

@imjasonh imjasonh closed this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants