Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/oauth2/google #1890

Merged

Conversation

hermanbanken
Copy link
Contributor

@hermanbanken hermanbanken commented Jan 21, 2022

Fixes #1889

Description
Ran:

go mod vendor # no changes
go get golang.org/x/oauth2/google
go mod vendor

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Updates google oauth2 to support workload identity

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@imjasonh imjasonh merged commit a59970f into GoogleContainerTools:main Jan 21, 2022
@hermanbanken hermanbanken deleted the update-docker-credential-gcr branch January 21, 2022 16:50
@imjasonh
Copy link
Collaborator

Just checking, the image including your commit is now available (https://gcr.io/kaniko-project/executor:a59970f4ac2a67ed54eb5e2277a1469bf4dc7c29) -- can you confirm this solves your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-credential-gcr: Workload Identity Federation
2 participants