Start keyless signing kaniko releases #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
approved these changes
Dec 16, 2021
Comment on lines
95
to
96
| GITHUB_SHA: ${{ github.sha }} | ||
| GITHUB_REF: ${{ github.ref }} |
There was a problem hiding this comment.
These seem to be redundant FYI: https://docs.github.com/en/actions/learn-github-actions/environment-variables
mattmoor
force-pushed
the
keyless-signing
branch
from
c9089aa
to
c440ef8
Compare
mattmoor
changed the title
|
Rebased this one, I think it's the last one! |
imjasonh
approved these changes
Dec 17, 2021
priyawadhwa
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP until #1840 merges.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
cc @priyawadhwa @dlorenc @imjasonh