Migrate to golang 1.14 #1098
Merged
Migrate to golang 1.14 #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we may want to hold off on this for a while with how unstable things have been lately. @tejal29 wdyt? |
|
@cvgw Agreed. However, feel free to still review or approve things. I have created a label "candidate-release-0.19.0" for such PRs. I am going to merge them after v0.18.0 release. |
tejal29
approved these changes
Mar 12, 2020
* Upgrade go.mod file * Upgrade travis file * Run rm -rf vendor && go mod tidy && go mod vendor to upgrade vendor/modules.txt according to golang 1.14 * Upgrade golangci-lint version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade go.mod file
Upgrade travis file
Run
rm -rf vendor && go mod tidy && go mod vendorto upgrade vendor/modules.txt according to golang 1.14Upgrade golangci-lint version
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes