Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration suite should build images only for tests that will actually be run #897

Closed
cvgw opened this issue Dec 2, 2019 · 0 comments · Fixed by #898
Closed

Integration suite should build images only for tests that will actually be run #897

cvgw opened this issue Dec 2, 2019 · 0 comments · Fixed by #898
Assignees
@cvgw
Labels
area/internal bugs related to kaniko development workflow kind/enhancement New feature or request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@cvgw
Copy link
Contributor

cvgw commented Dec 2, 2019

The way we currently setup the integration suite means that we build every docker image before a single test is run. This means that when the user specifies a specific pattern for tests like -run TestLayers/test_layer_Dockerfile_test_copy_bucket a lot of unnecessary images are built.

The integration test suite should be updated so that only the images explicitly required for the tests which will execute are built.
@cvgw cvgw added kind/enhancement New feature or request priority/p3 agreed that this would be good to have, but no one is available at the moment. area/internal bugs related to kaniko development workflow labels Dec 2, 2019
@cvgw cvgw mentioned this issue Dec 2, 2019
Closed
@cvgw cvgw self-assigned this Dec 2, 2019
@cvgw cvgw mentioned this issue Dec 2, 2019
Merged
4 tasks
cvgw added a commit to cvgw/kaniko that referenced this issue Dec 2, 2019
@cvgw
Fix GoogleContainerTools#897 - only build required docker images
14542a0 
Only build the docker images required for the integration tests which
will be executed rather than building all docker images every time.
cvgw added a commit to cvgw/kaniko that referenced this issue Dec 2, 2019
@cvgw
Fix GoogleContainerTools#897 - only build required docker images
c2645b2 
Only build the docker images required for the integration tests which
will be executed rather than building all docker images every time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvgw cvgw

Labels
area/internal bugs related to kaniko development workflow kind/enhancement New feature or request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only build required docker images for integration tests cvgw/kaniko
1 participant
@cvgw