The --log-timestamp=false
option does not properly pass down TextFormatter
into logrus.TextFormatter
#3213
Labels
area/cli
bugs related to kaniko CLI
area/logging
For all bugs related to logging
good first issue
Good for newcomers
help wanted
Looking for a volunteer!
kind/bug
Something isn't working
priority/p2
High impact feature/bug. Will get a lot of users happy
Actual behavior
When passing in
--log-timestamp=false
with either--log-format=text|color
set, timestamps still get logged.Expected behavior
No timestamps should get logged
To Reproduce
Steps to reproduce the behavior:
--log-timestamp=false
and--log-format=text
and notice timestamps still get logged.Additional Information
Triage Notes for the Maintainers
The culprit appears to be here:
kaniko/pkg/logging/logging.go
Lines 50 to 59 in 6bea4df
This code should be utilizing the
DisableTimestamp
field instead of theFullTimestamp
field in the logrus text formatter. See below:https://github.com/sirupsen/logrus/blob/dd1b4c2e81afc5c255f216a722b012ed26be57df/text_formatter.go#L48-L50
--cache
flagThe text was updated successfully, but these errors were encountered: