-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration TestRelativePaths fails to build #1092
Comments
It looks like that test was added in #736 but I'm not sure how it could have ever passed. What creates |
cc @tejal29 |
It's not clear to me what scenario this is supposed to be testing. Is @huguesalary perhaps you can provide some insight into what the intention behind this test was? |
Perhaps this is an example of the scenario which should be tested?
edit It does appear this is a valid scenario for the test. Kaniko fails to build this example without the code added in #736 I've created two branches to demonstrate this cvgw/kaniko@1092-debugging-pre |
Fix integraton test TestRelativePaths
Fix integraton test TestRelativePaths
Fix integraton test TestRelativePaths
Actual behavior
The image for TestRelativePaths fails to build, we didn't notice this because the error return by the builder method was not checked
kaniko/integration/integration_test.go
Line 390 in 8d2b205
Expected behavior
The test builds and passes successfully
Triage Notes for the Maintainers
--cache
flagThe text was updated successfully, but these errors were encountered: