Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update v2 defaults in cloud run #252

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: Update v2 defaults in cloud run #252

wants to merge 4 commits into from
+7 −0

Conversation

qz267
Copy link
Contributor

@qz267 qz267 commented Oct 15, 2024

No description provided.

@qz267 qz267 requested review from prabhu34, anamer, gtsorbo, q2w and a team as code owners October 15, 2024 19:46
@qz267 qz267 requested a review from q2w October 17, 2024 16:38
@q2w
Copy link
Collaborator

q2w commented Oct 18, 2024

/gcbrun

@q2w
Copy link
Collaborator

q2w commented Oct 18, 2024

/gcbrun

@q2w q2w enabled auto-merge (squash) October 18, 2024 06:10
@q2w
Copy link
Collaborator

q2w commented Oct 18, 2024

/gcbrun

@qz267
Copy link
Contributor Author

qz267 commented Oct 18, 2024 

Step #3 - "create standalone": === RUN   TestSecureCloudRunStandalone
Step #3 - "create standalone": TestSecureCloudRunStandalone 2024-10-18T10:07:21Z command.go:100: Running command gcloud with args [access-context-manager policies list --organization=943740911108 --format value(name)]
Step #3 - "create standalone":     gcloud.go:110: Error parsing output, invalid json: 
Step #3 - "create standalone": --- FAIL: TestSecureCloudRunStandalone (1.20s)
Step #3 - "create standalone": FAIL
Step #3 - "create standalone": FAIL	github.com/terraform-google-modules/terraform-example-foundation/test/integration/secure_cloud_run_standalone	1.257s
Step #3 - "create standalone": FAIL
Step #3 - "create standalone": t=2024-10-18T10:07:22+0000 lvl=eror msg="error running command: exit status 1"
Finished Step #3 - "create standalone"

hmm, invalid Json indicates the yaml fmt issue to me.

auto-merge was automatically disabled October 18, 2024 19:16

Head branch was pushed to by a user without write access

@q2w q2w enabled auto-merge (squash) October 23, 2024 14:22
@q2w
Copy link
Collaborator

q2w commented Oct 23, 2024

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q2w q2w q2w approved these changes

@prabhu34 prabhu34 Awaiting requested review from prabhu34 prabhu34 is a code owner

@anamer anamer Awaiting requested review from anamer anamer is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo gtsorbo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qz267 @q2w