Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check v2 module for any diff after apply #226

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Aug 8, 2024

Adds default verify to check for diff. Also a few other misc fixes when I tested locally

  • Switched to using new built in SA
  • Splat operator requires defaults to be null rather than {} to produce empty array so updated those cases
  • Added v2 tests to CI

@bharathkkb bharathkkb requested review from prabhu34, anamer, gtsorbo and a team as code owners August 8, 2024 19:58
@bharathkkb bharathkkb merged commit de9ee71 into main Aug 12, 2024
7 checks passed
@bharathkkb bharathkkb deleted the bharathkkb-patch-1 branch August 12, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants