feat: added v2 service as submodule #200
Conversation
|
/gcbrun |
|
/gcbrun |
| @@ -0,0 +1,86 @@ | |||
| # Cloud Run v2 Service | |||
There was a problem hiding this comment.
Should a metadata.yaml file be created for this new module? I don't see metadata.yaml available for this module. But we do have this file for modules present in https://github.com/terraform-google-modules
There was a problem hiding this comment.
I am not very sure of a metadata.yaml files usage. @bharathkkb Should I generate them?
There was a problem hiding this comment.
@prabhu34 you can set this in makefile to autogenerate https://github.com/terraform-google-modules/terraform-google-folders/blob/696570e8cf5d996336b586c9293ae6fea3edf98c/Makefile#L79
go/blueprints-metadata has more instructions but feel free to do this in a follow up to not block this PR
There was a problem hiding this comment.
I have created the metadata now. Seems like the Makefile was outdated and I had added the env to the generate_docs.
|
@q2w Feel free to make changes and amend! |
|
/gcbrun |
|
/gcbrun |
|
@bharathkkb For your second review with changes. |
| dynamic "containers" { | ||
| for_each = var.containers | ||
| content { | ||
| name = containers.value.container_name |
There was a problem hiding this comment.
Could we use key rather than using a separate container_name?
There was a problem hiding this comment.
I tried that earlier, but having a container name is optional input and container image will be a bigger key name. Let me know your thoughts!
There was a problem hiding this comment.
Made it list(objects) instead.
| tag = traffic.value.tag | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need to ignore chnage any annotations added by the service like
terraform-google-cloud-run/main.tf
Line 192 in b59b700
There was a problem hiding this comment.
I guess these are not needed as they will be part of effective_annotations and we can add them later if really needed.
|
/gcbrun |
|
/gcbrun |
cloud_run_v2_servicesubmodule@bharathkkb @q2w