-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: adds support to multiple service projects and Shared VPC #115
feat!: adds support to multiple service projects and Shared VPC #115
Conversation
afe6228
to
060e732
Compare
…d VPC in a network project
060e732
to
a9a8297
Compare
3896c72
to
7bbffea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, and waiting on @bharathkkb with regards to renaming submodules
I have not tested this before but I believe what will happen is TF registry will stop tracking old version after current release and these will be added as new submodules. I generally don't recommend this unless there is a strong rationale. Like Grant mentioned, we should rename the versions.tf to reflect new name though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add validation to harness as well, then LGTM
Please write some upgrade notes regarding the submodule name change to inform users of navigating the breaking change
hey @gtsorbo where should I put these notes? in the modules readmes? |
|
75a63c0
to
72102ab
Compare
72102ab
to
c430803
Compare
/gcbrun |
Hey folks,
this PR adds support to multiple services project and the creation of a Shared VPC in a network project in the harness sub-module.
Could you, please, take a look on it?