feat!: changes net module to be serverless generic #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandakarina
requested review from
a team,
prabhu34,
anamer and
mitchelljamie
as code owners
amandakarina
changed the title
prabhu34
approved these changes
Apr 10, 2023
amandakarina
changed the title
amandakarina
changed the title
amandakarina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
This PR renames the secure-cloud-run-net module to secure-cloud-serverless-net.
It also removes the Service Identity retrieve from net module and receives as a variable.
This will allow this module to be re-used by secure-cloud-function.
Could you, please, take a look on it?
Thanks!