Skip to content

fix: #9165 Command wait -n is redundant #9176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2023
Merged

fix: #9165 Command wait -n is redundant #9176

merged 3 commits into from
Feb 27, 2023

Conversation

rsamborski
Copy link
Member

Description

Fixes #9165

Command wait -n is redundant

Checklist

@rsamborski rsamborski requested review from a team as code owners February 27, 2023 12:34
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. labels Feb 27, 2023
@rsamborski rsamborski assigned engelke and unassigned engelke Feb 27, 2023
@rsamborski rsamborski requested a review from engelke February 27, 2023 12:35
@rsamborski rsamborski mentioned this pull request Feb 27, 2023
Closed
@leahecole leahecole merged commit d8a9c37 into main Feb 27, 2023
@leahecole leahecole deleted the fix_9165 branch February 27, 2023 15:36
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@rsamborski @kweinmeister
@leahecole @telpirion
fix: #9165 Command wait -n is redundant (#9176)
8de7e07 
Co-authored-by: Karl Weinmeister <11586922+kweinmeister@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

@engelke engelke Awaiting requested review from engelke

Assignees

@loferris loferris

Labels
api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command wait -n after exec may not work and seems to be redundant in example
5 participants
@rsamborski @leahecole @kweinmeister @engelke @loferris