Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppai/land-cover: simplify tests and pin python version #8501

Merged
merged 7 commits into from
Nov 16, 2022

Conversation

davidcavazos
Copy link
Contributor

@davidcavazos davidcavazos commented Nov 11, 2022

Description

Simplify tests, update dependency versions, and add notebook links to README.

Fixes: #8434

Checklist

@davidcavazos davidcavazos requested a review from a team as a code owner November 11, 2022 23:16
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 11, 2022
@davidcavazos davidcavazos force-pushed the ppai-simplify-tests branch 2 times, most recently from 0731aa6 to a372581 Compare November 11, 2022 23:21
@davidcavazos davidcavazos added the blunderbuss: assign Instruct blunderbuss to assign someone label Nov 11, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Nov 11, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kurtisvg kurtisvg removed their assignment Nov 14, 2022
@davidcavazos davidcavazos changed the title ppai/land-cover: simplify tests ppai/land-cover: simplify tests and pin python version Nov 14, 2022
@davidcavazos davidcavazos added the blunderbuss: assign Instruct blunderbuss to assign someone label Nov 16, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Nov 16, 2022
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 089ee19 into GoogleCloudPlatform:main Nov 16, 2022
@davidcavazos davidcavazos deleted the ppai-simplify-tests branch November 16, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

people-and-planet-ai.land-cover-classification.e2e_test: test_land_cover_tensorflow failed
6 participants