Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): ignore python 3.10 #8282

Merged
merged 2 commits into from
Aug 23, 2022
Merged

fix(pubsublite): ignore python 3.10 #8282

merged 2 commits into from
Aug 23, 2022

Conversation

anguillanneuf
Copy link
Member

Fixes #8275
Fixes #8276

Flaky when running on multiple python versions. Really only one version is sufficient.

@anguillanneuf anguillanneuf requested review from hongalex and a team as code owners August 23, 2022 18:31
@product-auto-label product-auto-label bot added api: pubsublite Issues related to the Pub/Sub Lite API. samples Issues that are directly related to samples. labels Aug 23, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anguillanneuf
Copy link
Member Author

anguillanneuf commented Aug 23, 2022

@dandhlee This is a weird error for the test:

RROR: This script does not work on Python 3.6 The minimum supported Python version is 3.7. Please use https://bootstrap.pypa.io/pip/3.6/get-pip.py instead.
The command '/bin/sh -c wget --no-check-certificate -O /tmp/get-pip.py 'https://bootstrap.pypa.io/get-pip.py' && python3.6 /tmp/get-pip.py "pip==$PYTHON_PIP_VERSION" && pip3 install --no-cache-dir --upgrade --force-reinstall "pip==$PYTHON_PIP_VERSION" && [ "$(pip list |tac|tac| awk -F '[ ()]+' '$1 == "pip" { print $2; exit }')" = "$PYTHON_PIP_VERSION" ]' returned a non-zero code: 1

https://source.cloud.google.com/results/invocations/df2528fc-34a2-4e76-9143-0d685f6a6a97/targets/cloud-devrel%2Fpython-docs-samples%2Fpython3.9%2Fpresubmit/log

Have we misconfigured something?


And the error went away.

@dandhlee
Copy link
Collaborator

Kokoro should never have that much logs being generated from Docker build, it does happen from time to time with system errors. Since it worked I wouldn't worry, usually it's a thing on the Kokoro side (we did have Kokoro team tell us they had an update this morning and things have been slow today)

@anguillanneuf anguillanneuf merged commit c727880 into main Aug 23, 2022
@anguillanneuf anguillanneuf deleted the pubsublite-flaky branch August 23, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. samples Issues that are directly related to samples.
Projects
None yet
4 participants