Skip to content

Conversation

@pallabiwrites
Copy link
Contributor

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

@pallabiwrites pallabiwrites requested review from a team as code owners August 18, 2021 04:04
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 18, 2021
@google-cla
Copy link

google-cla bot commented Aug 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 18, 2021
@google-cla
Copy link

google-cla bot commented Aug 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request, cleaning up this code. LGTM, so after you sign the CLA and we have another review, we will merge it.

@pallabiwrites
Copy link
Contributor Author

pallabiwrites commented Aug 18, 2021 via email

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 18, 2021
@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this in!

For what it's worth, following e.g. with a comma is not a formal standard in some parts of the world. It seems like it may be a case in the US, but not for UK. Nothing wrong with what we have here, but in case anyone thinks that this is mandatory that it's up to the writer.

@dandhlee dandhlee changed the title Review the language fixes. chore: Review the language fixes. Aug 18, 2021
@dandhlee
Copy link
Collaborator

Merging without product DPE approval as it's just comment changes.

@dandhlee dandhlee merged commit ecc98ba into GoogleCloudPlatform:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants