-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: Review the language fixes. #6591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed formatting changes.
Fixed minor language issues.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
engelke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pull request, cleaning up this code. LGTM, so after you sign the CLA and we have another review, we will merge it.
|
Hi Charles,
Thanks. I have signed the CLA.
Regards,
Pallabi
…On Wed, Aug 18, 2021 at 9:37 PM Charles Engelke ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for this pull request, cleaning up this code. LGTM, so after you
sign the CLA and we have another review, we will merge it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6591 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU35UOAIT4XF2XS5K6PWULTT5PLEJANCNFSM5CLFLNSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
dandhlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this in!
For what it's worth, following e.g. with a comma is not a formal standard in some parts of the world. It seems like it may be a case in the US, but not for UK. Nothing wrong with what we have here, but in case anyone thinks that this is mandatory that it's up to the writer.
|
Merging without product DPE approval as it's just comment changes. |
Description
Fixes #
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)