Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update AUTHORING_GUIDE #5872

Merged
merged 13 commits into from
May 24, 2021
Merged

docs: update AUTHORING_GUIDE #5872

merged 13 commits into from
May 24, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 21, 2021 •
edited
Loading

Update the Authoring Guide with more information from the internal doc, and added a FAQs section.

Paired with cl/375155564.

@busunkim96 busunkim96 requested a review from a team as a code owner May 21, 2021 22:11
@snippet-bot
Copy link

snippet-bot bot commented May 21, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2021
leahecole
leahecole reviewed May 21, 2021
View reviewed changes
leahecole
leahecole reviewed May 21, 2021
View reviewed changes
busunkim96 and others added 2 commits May 21, 2021 22:14
@busunkim96
chore: adjust headers
2ef6864
@busunkim96 @leahecole
Update AUTHORING_GUIDE.md
60be9e8 
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
leahecole
leahecole reviewed May 21, 2021
View reviewed changes
busunkim96 and others added 3 commits May 21, 2021 22:17
@busunkim96
fix link
e3aa1db
@busunkim96 @leahecole
Update AUTHORING_GUIDE.md
437fc89 
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@busunkim96 @leahecole
Update AUTHORING_GUIDE.md
2902069 
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
leahecole
leahecole requested changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few nits - mostly just markdown errors and reformatting

@busunkim96 busunkim96 requested a review from leahecole May 21, 2021 23:04
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8f7674e into master May 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the authoring-guide-updates branch May 24, 2021 17:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2021
jacek-izykowski pushed a commit to jacek-izykowski/python-docs-samples that referenced this pull request Jul 13, 2021
@busunkim96 @jacek-izykowski
docs: update AUTHORING_GUIDE (GoogleCloudPlatform#5872)
61de8c6 

Update the Authoring Guide with more information from the internal doc, and added a FAQs section.

Paired with cl/375155564.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @leahecole @kurtisvg @dandhlee