Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency Flask to v2.0.0 #5838

Merged
merged 6 commits into from
May 17, 2021
Merged

chore(deps): update dependency Flask to v2.0.0 #5838

merged 6 commits into from
May 17, 2021

Conversation

dandhlee
Copy link
Collaborator

Continuing the work from #5815, upgrading the requirements for Flask to 2.0.0, and keeping it at 1.1.4 for Python 2.7 specific tests since Flask 2.0.0 is dropping support for Python 2.

@dandhlee dandhlee requested a review from a team as a code owner May 14, 2021 19:31
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2021
@dandhlee
Copy link
Collaborator Author

./appengine/flexible/websocketstests are failing, trying to see if reverting it to 1.1.4 works

@leahecole leahecole changed the title chore(deps): update dependancy Flask to v2.0.0 chore(deps): update dependency Flask to v2.0.0 May 14, 2021
@dandhlee
Copy link
Collaborator Author

AppEngine Flex tests seem to be fine. Downgrading for Telemetry requirements as some specifically require Flask to be ~=1.0 or <2.0

@leahecole
Copy link
Collaborator

For the opentelemetry ones, can you add a comment to the requirements file and link to anything that shows that constraint? that way when renovate inevitably opens up another PR to upgrade it, we know where to check to see if we should keep ignoring or not

@dandhlee
Copy link
Collaborator Author

Done! Thanks for pointing that out 😄

@leahecole leahecole merged commit 3440f10 into master May 17, 2021
@leahecole leahecole deleted the flask_2 branch May 17, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants