Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pip version override for virtualenv in nox #5806

Merged
merged 8 commits into from
May 14, 2021
Merged

add pip version override for virtualenv in nox #5806

merged 8 commits into from
May 14, 2021

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented May 7, 2021 •
edited
Loading

Description

Needed in #5782

Note: It's a good idea to open an issue first for discussion.

Checklist

@leahecole leahecole requested a review from a team as a code owner May 7, 2021 19:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 7, 2021
dandhlee
dandhlee approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

noxfile_config.py Outdated Show resolved Hide resolved
@leahecole
Copy link
Collaborator Author

sry I'm making a git mess w/ noxfile_configs I'll fix it in a sec

@leahecole
Copy link
Collaborator Author

sry I'm making a git mess w/ noxfile_configs I'll fix it in a sec

Fixed

@leahecole leahecole merged commit f8bf1a7 into master May 14, 2021
@leahecole leahecole deleted the add_pip_version_override branch May 14, 2021 22:16
This was referenced May 14, 2021
Merged
Merged
gcf-merge-on-green bot pushed a commit to googleapis/synthtool that referenced this pull request May 21, 2021
@leahecole
feat: add pip version override to python samples noxfile (#1096)
bb5ef5a 
Companion to GoogleCloudPlatform/python-docs-samples#5806
@meredithslota meredithslota mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@engelke engelke engelke approved these changes

Assignees

@busunkim96 busunkim96

@dandhlee dandhlee

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leahecole @engelke @dandhlee @busunkim96