-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new django tutorial #4869
Merged
Merged
Add new django tutorial #4869
Changes from 1 commit
Commits
Show all changes
119 commits
Select commit
Hold shift + click to select a range
ff73fca
Cloud Run with Django tutorial
glasnt b5ccc3c
Cloud Run with Django tutorial
glasnt 6ea8b1b
Merge branch 'tutorial/django-run' of github.com:glasnt/python-docs-s…
glasnt 1ba9285
black, .env file update
glasnt e6c9362
Document Dockerfile, add PYTHONUNBUFFERED
glasnt 7cd94bb
Document cloudmigrate.yaml
glasnt 01fbedf
Formatiting
glasnt 711a50f
Bump django, remove mysql
glasnt b01118d
Merge branch 'master' into tutorial/django-run
glasnt 97088bd
Update secretmanager
glasnt a3960e8
Update pinned dependencies
glasnt c0a4753
ensure path is set correctly with api update
glasnt e75ee59
format
glasnt 55db6c4
Generalise cloudmigrate file
glasnt b0d3e61
update service default
glasnt b39521b
add tests
glasnt a0c90a4
Update CODEOWNERS
glasnt 79a0c11
Merge branch 'master' into django-run
glasnt 60f54fd
Merge branch 'master' into django-run
glasnt 083145a
Licence headers
glasnt 0508de3
Remove envvar declaration
glasnt 4ae043e
cleanup readme
glasnt 0fea1a4
Fix import names, region tags
glasnt 59a690a
black
glasnt 3297a13
Merge branch 'django-run' of github.com:glasnt/python-docs-samples in…
glasnt 43311df
Cloud Run with Django tutorial
glasnt 192547a
black, .env file update
glasnt 4d8ec6f
Document Dockerfile, add PYTHONUNBUFFERED
glasnt 9fb3094
Document cloudmigrate.yaml
glasnt 885d44f
Formatiting
glasnt b56ecdf
Bump django, remove mysql
glasnt 3897bad
Update secretmanager
glasnt a453f02
Update pinned dependencies
glasnt 7981375
ensure path is set correctly with api update
glasnt 756daf9
format
glasnt 86573fe
Generalise cloudmigrate file
glasnt 9a94cb2
update service default
glasnt 6426d01
add tests
glasnt 8fa8c19
Update CODEOWNERS
glasnt be5911a
Licence headers
glasnt cb5992e
Remove envvar declaration
glasnt 8c643d4
cleanup readme
glasnt 98837e1
Fix import names, region tags
glasnt 5e1cb0a
black
glasnt 0308d64
Merge branch 'django-run' of github.com:glasnt/python-docs-samples in…
glasnt 911ca50
black
glasnt 877c658
Format YAML
glasnt 700a2cd
Merge branch 'master' into django-run
glasnt 466a801
bump dependencies
glasnt c188733
Update var names, remove sql instance creation
glasnt 4d33c68
PR Feedback
glasnt 344f35e
Merge branch 'master' into django-run
glasnt 3ed2a6e
Debug failing command
glasnt 8fa7cc3
Merge branch 'django-run' of github.com:glasnt/python-docs-samples in…
glasnt 8f854e9
Remove IAM calls - possible permissions issues
glasnt 1809ab5
debug
glasnt cefb39a
force local settings if in nox/test
glasnt 2b61310
add IDs to cloud build
glasnt cd0b8d1
Update region tags
glasnt 9492d67
Get instance name from envvar
glasnt 2601b22
Make secrets dynamic, optionally overload names by envvar
glasnt 2ca3427
Remove create/destroy of static setting
glasnt f1b79c2
Consolidate envvars
glasnt e9cbe76
Merge branch 'master' into django-run
glasnt e8556fc
Merge branch 'django-run' of github.com:glasnt/python-docs-samples in…
glasnt 738a9b5
fix region tags
glasnt e62e4d3
lint, import error
glasnt e51cd2b
Testing instance name is fqdn, need just name for gcloud sql calls
glasnt 7837611
Ensure project specified on gcloud calls
glasnt 460b5ff
set project when using gsutil
glasnt 6fce68c
order of flags in gsutil matters
glasnt 2b09698
ensure all subprocesses include project
glasnt cb5ea1e
Add and remove more project tags
glasnt 9877d70
Update comments
glasnt 04c0900
match on exact project name, not substring
glasnt 895f8fb
lint
glasnt 05aa42c
Can't hide the settings name in the setting itself 🧐
glasnt 1db86b5
big oof
glasnt d8a557f
migrations require __init__.py to be detected
glasnt 87ebb84
Bump overnight patch
glasnt adc6fda
Debug 503
glasnt 4a956fb
Service requires custom settings envvar
glasnt 9a48ab4
attempt fixing local tests
glasnt 6d544f2
lint
glasnt 7986d66
Merge branch 'master' into django-run
glasnt 7ffff2d
revert accidental appengine change
glasnt d529d19
envvars
glasnt e6caaf7
Merge branch 'django-run' of github.com:glasnt/python-docs-samples in…
glasnt 1edf555
ohno
glasnt d95a698
wrong varname
glasnt 9bf42d4
Merge branch 'master' into django-run
glasnt 28b12a0
Merge branch 'master' into django-run
glasnt c55cdea
Merge branch 'master' into django-run
glasnt c7034b1
Update run/django/noxfile_config.py
glasnt 14371a4
Add licence header
glasnt e31e692
Formatting
glasnt e4dd31f
black
glasnt 8712b3f
Add typehinting, remove debugging
glasnt eeca3c2
Merge branch 'master' into django-run
glasnt 652d5ee
⚠️ noxfile change - add typehints
glasnt 08d2961
⚠️ noxfile change - fix method signature
glasnt e441b59
⚠️ noxfile change - fix nox session type
glasnt 763ad5b
⚠️ noxfile change - import order
glasnt 82df36f
hadolint Dockerfile
glasnt 5395697
revert hadolint
glasnt 620b626
Merge branch 'master' into django-run
glasnt e1d465c
Merge branch 'master' into django-run
glasnt 4f1063a
Merge branch 'master' into django-run
glasnt 0d78748
Merge branch 'master' into django-run
glasnt 80c66ab
Merge branch 'master' into django-run
glasnt 2fd21a4
Merge branch 'master' into django-run
glasnt a18d3fe
Add linking
glasnt 5e78fdb
Remove gcloudignore
glasnt 2109542
Merge branch 'django-run' of github.com:glasnt/python-docs-samples in…
glasnt 6f9c0ff
Merge branch 'master' into django-run
glasnt 7dd2052
Merge branch 'master' into django-run
glasnt 60699a9
Testing: i have a theory this is why tests started failing
glasnt 2574096
Merge branch 'django-run' of github.com:glasnt/python-docs-samples in…
glasnt 83fc6b2
Merge branch 'master' into django-run
glasnt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
set project when using gsutil
- Loading branch information
commit 460b5ff207940b907dd8581211d1759c6bec7a89
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kurtisvg is postgres one of the few static instances that we actually are okay with not having a fixture for because it takes super long to spin up and tear down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes (see the Sample Style Guide).
The instance should be provided via env var, however either the database or the table(s) used should be created on the fly (and should use a UUID).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like inline documentation about this choice, or can I resolve this conversation without any edits?