Adding e2e test for pubsub sample #4835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
grant
approved these changes
Oct 9, 2020
dinagraves
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dinagraves
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dinagraves
added
the
kokoro:force-run
dinagraves
added
kokoro:force-run
dinagraves
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dinagraves
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dinagraves
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
product-auto-label
bot
added
the
samples
averikitsch
approved these changes
Oct 12, 2020
| # Retry a maximum number of 10 times to find results in stackdriver | ||
| found = False | ||
| for x in range(10): | ||
| iterator = client.list_log_entries(resource_names, filter_=filters) |
There was a problem hiding this comment.
Maybe add a sleep in between tries
There was a problem hiding this comment.
Added! Also realized I was only breaking from the inner loop so added an extra break statement for the outer loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding end to end tests for the pub/sub sample. B/c pub/sub doesn't return a message from the service, it uses the logging API to check that the service handled the message properly.