Update logging example to retrieve the default handler #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tmatsuo
reviewed
May 5, 2020
logging/cloud-client/handler.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env python | |||
|
|
|||
| # Copyright 2016 Google Inc. All Rights Reserved. | |||
| # Copyright 2020 Google Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
Don't update the copyright year
kurtisvg
suggested changes
May 5, 2020
logging/cloud-client/handler.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env python | |||
|
|
|||
| # Copyright 2016 Google Inc. All Rights Reserved. | |||
| # Copyright 2020 Google Inc. All Rights Reserved. | |||
kurtisvg
approved these changes
May 6, 2020
kurtisvg
added
the
automerge
busunkim96
pushed a commit
to busunkim96/python-logging
that referenced
this pull request
Oct 12, 2020
…leCloudPlatform/python-docs-samples#3691) * Update handler.py * Update README.rst * Update handler.py Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
busunkim96
pushed a commit
to busunkim96/python-logging
that referenced
this pull request
Oct 30, 2020
…leCloudPlatform/python-docs-samples#3691) * Update handler.py * Update README.rst * Update handler.py Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
busunkim96
pushed a commit
to googleapis/python-logging
that referenced
this pull request
Oct 30, 2020
…leCloudPlatform/python-docs-samples#3691) * Update handler.py * Update README.rst * Update handler.py Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the code sample usable for App Engine apps as well as other environments.
When a Logging client asks for the default handler, Logging returns a handler that is appropriate for the environment the client is running in. When the code is running in App Engine, AppEngineHandler is returned, and this is needed to enable key logging features in App Engine, such as correlating app logs with request logs.
Here's info about get_default_handler():
https://googleapis.dev/python/logging/latest/client.html
This change also updates branding to "Cloud Logging".