run: Dockerfile COPY to ./ #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dinagraves
approved these changes
May 1, 2020
averikitsch
approved these changes
May 1, 2020
tmatsuo
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the Dockerfile sample practices we attempt on Cloud Run is to use
./as the default destination of DockerfileCOPYstatements.It doesn't really change the behaviors we expect:
COPY . .=COPY . ./COPY README.md .=COPY README.md ./=COPY README.md README.mdHowever, it matters when developers try to use the multi-source arguments option with COPY:
COPY README.md main.py .= ERROR!!COPY README.md main.py ./= Happy Dance 👯By using
./wherever just a.appears, it adds a little more noise to the Dockerfile but in exchange there's one less source of friction if developers iterate on top of the Dockerfiles we provide.I'm working on standardizing this further, but for now sending a little PR to nudge Cloud Run Python alignment.