-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cloud run system package sample #2554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few requested changes.
Required to run tests for this Sample: GoogleCloudPlatform/python-docs-samples#2554
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending a stronger test assertion.
fae36ff
to
ce603e6
Compare
…ython-docs-samples into run-system-package
Required to run tests for this Sample: GoogleCloudPlatform/python-docs-samples#2554
Required to run tests for this Sample: GoogleCloudPlatform/python-docs-samples#2554
…amples into run-system-package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes on string formatting. Otherwise LGTM, will merge once CI is green
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
This sample should not run with 2.7. Issue filed for the incomplete skip in #2596 |
Required to run tests for this Sample: GoogleCloudPlatform/python-docs-samples#2554
Creating python sample for https://cloud.google.com/run/docs/tutorials/system-packages.
This sample Cloud Run service demonstrates using a customized Dockerfile to configure system packages whose command-line utilities are used as part of serving HTTP requests.