Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cloud run system package sample #2554

Merged
merged 22 commits into from
Dec 10, 2019
Merged

Adding Cloud run system package sample #2554

merged 22 commits into from
Dec 10, 2019

Conversation

dinagraves
Copy link
Contributor

Creating python sample for https://cloud.google.com/run/docs/tutorials/system-packages.

This sample Cloud Run service demonstrates using a customized Dockerfile to configure system packages whose command-line utilities are used as part of serving HTTP requests.

@dinagraves dinagraves requested review from grayside and grant November 18, 2019 22:53
@dinagraves dinagraves requested a review from a team as a code owner November 18, 2019 22:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2019
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few requested changes.

run/system-package/Dockerfile Show resolved Hide resolved
run/system-package/README.md Outdated Show resolved Hide resolved
run/system-package/main.py Show resolved Hide resolved
run/system-package/main.py Outdated Show resolved Hide resolved
run/system-package/main.py Outdated Show resolved Hide resolved
run/system-package/main.py Show resolved Hide resolved
run/system-package/main.py Outdated Show resolved Hide resolved
run/system-package/main.py Show resolved Hide resolved
run/system-package/main_test.py Outdated Show resolved Hide resolved
@dinagraves dinagraves requested a review from grant November 19, 2019 18:55
dinagraves added a commit to dinagraves/testing-infra-docker that referenced this pull request Nov 25, 2019
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a stronger test assertion.

@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
dinagraves added a commit to dinagraves/testing-infra-docker that referenced this pull request Dec 5, 2019
kurtisvg pushed a commit to googleapis/testing-infra-docker that referenced this pull request Dec 5, 2019
@dinagraves dinagraves added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
@dinagraves dinagraves added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2019
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes on string formatting. Otherwise LGTM, will merge once CI is green

run/system-package/main.py Outdated Show resolved Hide resolved
run/system-package/main.py Outdated Show resolved Hide resolved
dinagraves and others added 3 commits December 10, 2019 12:55
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@busunkim96
Copy link
Contributor

This sample should not run with 2.7. Issue filed for the incomplete skip in #2596

@busunkim96 busunkim96 merged commit a09ca74 into master Dec 10, 2019
@busunkim96 busunkim96 deleted the run-system-package branch December 10, 2019 21:49
tswast pushed a commit to tswast/testing-infra-docker that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants