Added samples for handling CORS requests. #1652
Conversation
googlebot
added
the
cla: yes
|
@ace-n Completed requested changes. PTAL. |
|
|
||
| return ('', 204, headers) | ||
|
|
||
| # Set CORS headers for the main request |
There was a problem hiding this comment.
"The main request" is ambiguous here. Maybe we should just say "Set CORS headers" or perhaps "Set CORS headers for non-OPTIONS requests" if that is necessary? Also: same comment on similar line in next function.
functions/http/main.py
Outdated
| def cors_enabled_function(request): | ||
| # Set CORS headers for the preflight request | ||
| # e.g. allows GETs from any origin with the Content-Type header | ||
| # and cache preflight response for an 3600s |
There was a problem hiding this comment.
I don't understand this comment block. Can you try and explain it to me in more detail, and then we can use that explanation to clarify it?
functions/http/main.py
Outdated
| def cors_enabled_function_auth(request): | ||
| # Set CORS headers for preflight requests | ||
| # e.g. allows GETS from origin https://mydomain.com with Authorization | ||
| # header |
There was a problem hiding this comment.
Likewise I'm not sure I'm clear on this comment meaning yet.
|
Hi @andrewsg , Basically under certain circumstances browsers need to send one empty |
|
Okay. Here are some suggestions:
|
|
@andrewsg I'll LGTM this once you do. |
No description provided.