Create k8s-grpc-bookstore.yaml #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm in the process of adding a tutorial to the Endpoints gRPC docs for running the bookstore sample on Kubernetes (K8s). I need this file for the tutorial so that the only thing people have to configure is the SERVICE_NAME.
googlebot
added
the
cla: yes
kryzthov
reviewed
May 17, 2018
| # See the License for the specific language governing permissions and | ||
| # limitations under the License | ||
|
|
||
| apiVersion: v1 |
There was a problem hiding this comment.
I'd suggest adding a comment/description at the top, to explain in which circumstances this k8s descriptor should be used.
Here, I'd emphasize that this descriptor should be used on any K8s cluster that isn't running in GCP.
There was a problem hiding this comment.
I added comments to yaml files that the tutorials use.
simonz130
approved these changes
May 17, 2018
| image: gcr.io/endpoints-release/endpoints-runtime:1 | ||
| args: [ | ||
| "--http2_port=9000", | ||
| "--service=SERVICE_NAME", |
There was a problem hiding this comment.
Will the tutorial ask the person to change SERVICE_NAME manually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of adding a tutorial to the Endpoints gRPC docs for running the bookstore sample on Kubernetes (K8s). I need this file for the tutorial so that the only thing people have to configure is the SERVICE_NAME.